Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change href to match ms error token #209

Merged
merged 2 commits into from
Sep 9, 2023

Conversation

NoCatt
Copy link
Contributor

@NoCatt NoCatt commented Sep 2, 2023

this is for R2Northstar/NorthstarMods#648 ( and in part R2Northstar/NorthstarLauncher#468 ), this matches the href tag to the exact ms response so we can open the wiki section directly without hacky shenanigans

Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, this will be useful for R2Northstar/NorthstarMods#648

Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked that the changed anchor link still works.

Also confirmed that all occurrences of the old anchor links have been updated. CTRL+SHIFT+F found none that were missed.

@GeckoEidechse GeckoEidechse merged commit ed4ce62 into R2Northstar:main Sep 9, 2023
@NoCatt NoCatt deleted the change-href branch September 18, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants